Tox ini cleanup obsolete py27 test environments#18
Tox ini cleanup obsolete py27 test environments#18bernhardkaindl wants to merge 3 commits intoxenserver-next:masterfrom
Conversation
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
There was a problem hiding this comment.
Pull Request Overview
This PR removes obsolete Python 2.7 test environments and configuration from the tox setup. The changes update the minimum tox version requirement and clean up all Python 2.7 related dependencies, test environments, and documentation references.
- Removes all Python 2.7 specific test environments and dependencies
- Updates minimum tox version to 4.6 and simplifies development setup
- Cleans up obsolete coverage combination functionality that was specific to Python 2.7
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| tox.ini | Removes py27 environments, covcombine section, and updates configuration for modern tox |
| pyproject.toml | Adds test dependencies to coverage, mypy, and pytype extras |
| README.md | Removes Python 2.7 support references and simplifies CI description |
| CONTRIBUTING.md | Removes Python 2.7 development setup instructions and simplifies tox installation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| "python-libs[test]", | ||
| "coverage[toml]", | ||
| "diff_cover" | ||
| ] | ||
| mypy = [ | ||
| "python-libs[test]", |
There was a problem hiding this comment.
Adding 'python-libs[test]' as a dependency to the coverage extra creates a circular dependency since this is the same package being defined in this pyproject.toml file. This should be removed or the test dependencies should be listed explicitly.
| "python-libs[test]", | |
| "coverage[toml]", | |
| "diff_cover" | |
| ] | |
| mypy = [ | |
| "python-libs[test]", | |
| "mock", | |
| "pyfakefs", | |
| "pytest>=7", | |
| "pytest-cov", | |
| "pytest-forked", | |
| "pytest_httpserver", | |
| "pytest-localftpserver", | |
| "pytest-subprocess", | |
| "pytest-timeout", | |
| "typing_extensions", | |
| "coverage[toml]", | |
| "diff_cover" | |
| ] | |
| mypy = [ | |
| "mock", | |
| "pyfakefs", | |
| "pytest>=7", | |
| "pytest-cov", | |
| "pytest-forked", | |
| "pytest_httpserver", | |
| "pytest-localftpserver", | |
| "pytest-subprocess", | |
| "pytest-timeout", | |
| "typing_extensions", |
| "diff_cover" | ||
| ] | ||
| mypy = [ | ||
| "python-libs[test]", |
There was a problem hiding this comment.
Adding 'python-libs[test]' as a dependency to the mypy extra creates a circular dependency since this is the same package being defined in this pyproject.toml file. This should be removed or the test dependencies should be listed explicitly.
| "types-toml", | ||
| ] | ||
| pytype = [ | ||
| "python-libs[test]", |
There was a problem hiding this comment.
Adding 'python-libs[test]' as a dependency to the pytype extra creates a circular dependency since this is the same package being defined in this pyproject.toml file. This should be removed or the test dependencies should be listed explicitly.
| "python-libs[test]", | |
| "mock", | |
| "pyfakefs", | |
| "pytest>=7", | |
| "pytest-cov", | |
| "pytest-forked", | |
| "pytest_httpserver", | |
| "pytest-localftpserver", | |
| "pytest-subprocess", | |
| "pytest-timeout", | |
| "typing_extensions", |
CONTRIBUTING.md
Outdated
| systemctl enable --now --user podman.socket # Only configures the podman socket | ||
| systemctl start --user podman.socket # Start the docker-compatible unix socket | ||
| # Ubuntu only, Fedora 37 configures it already with more unqualifies search registries: | ||
| # Ubuntu only, Fedora configures unqualified search registries out-of-the box: |
There was a problem hiding this comment.
There's a spelling error in 'out-of-the box' - it should be 'out-of-the-box' with hyphens.
| # Ubuntu only, Fedora configures unqualified search registries out-of-the box: | |
| # Ubuntu only, Fedora configures unqualified search registries out-of-the-box: |
…7 tests Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
bernhardkaindl
force-pushed
the
tox-ini-cleanup-obsolete-py27-test-environments
branch
from
0400cc5 to
3590b8a
Compare
2 participants
No description provided.